C# Cannot convert from string [] to string

Question

I have this method and get the above error on the line words.Add(rows); can anyone help? Thanks - Ben

private static IEnumerable<string> LoadWords(String filePath)
    {

        List<String> words = new List<String>();

        try
        {
            foreach (String line in File.ReadAllLines(filePath))
            {
                string[] rows = line.Split(',');

                words.Add(rows);
            }

        }
        catch (Exception e)
        {
            System.Windows.MessageBox.Show(e.Message);
        }

            return words;
    }

For your own information, here Eric Lippert explains why it makes sense for Add and AddRange are separate functions. Here LBushkin goes into a bit more detail, looking at the technical limitations that make this choice necessary. Without those technical limitations, having two separate functions would still be a good idea, though. — Brian
– Brian, Commented Mar 18, 2011 at 17:38

BrokenGlass · Accepted Answer · 2011-03-18 16:31:22Z

6

Instead of

words.Add(rows);

use this :

words.AddRange(rows);

rows is a string array containing multiple strings, so you have to add them with AddRange().

answered Mar 18, 2011 at 16:31

BrokenGlass

161k28 gold badges297 silver badges339 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Cox · Accepted Answer · 2011-03-18 16:31:27Z

4

Change it to this

words.AddRange(rows);

You issue is that you are adding an array of items, not a single element.

You use AddRange() when adding a collection that implements System.Collections.Generic.IEnumerable<T>

See documentation here http://msdn.microsoft.com/en-us/library/z883w3dc.aspx

answered Mar 18, 2011 at 16:31

Matthew Cox

13.7k9 gold badges57 silver badges72 bronze badges

Comments

Adam Houldsworth · Accepted Answer · 2011-03-18 16:32:02Z

1

You are trying to add a string array to a list that takes a string.

Try words.AddRange(rows);

answered Mar 18, 2011 at 16:32

Adam Houldsworth

64.8k11 gold badges161 silver badges190 bronze badges

Comments

Avi · Accepted Answer · 2011-03-18 16:33:43Z

1

u r trying to add string of array in a list of array

private static IEnumerable<string> LoadWords(String filePath)
    {

        List<String> words = new List<String>();

        try
        {
            foreach (String line in File.ReadAllLines(filePath))
            {
                string[] rows = line.Split(',');

                foreach(string str in rows)
                       words.Add(str);
            }

        }
        catch (Exception e)
        {
            System.Windows.MessageBox.Show(e.Message);
        }

            return words;
    }

answered Mar 18, 2011 at 16:33

Avi

2511 gold badge4 silver badges14 bronze badges

Comments

Babak Naffas · Accepted Answer · 2011-03-18 16:31:59Z

0

You are using the wrong method. You want the AddRange method.

words.AddRange(rows);

answered Mar 18, 2011 at 16:31

Babak Naffas

12.6k3 gold badges36 silver badges51 bronze badges

Comments

zs2020 · Accepted Answer · 2011-03-18 16:32:01Z

0

Have a try of this:

words.AddRange(rows);

answered Mar 18, 2011 at 16:32

zs2020

54.7k30 gold badges157 silver badges223 bronze badges

Comments

iggymoran · Accepted Answer · 2011-03-18 16:32:08Z

0

.Add will take another string, not an array of strings.

Try .AddRange instead.

answered Mar 18, 2011 at 16:32

iggymoran

4,0992 gold badges24 silver badges26 bronze badges

Comments

user153923 · Accepted Answer · 2011-03-18 16:33:17Z

0

private static IEnumerable<string> LoadWords(String filePath)
{

    List<String> words = new List<String>();

    try
    {
        foreach (String line in File.ReadAllLines(filePath))
        {
            string[] rows = line.Split(',');

            foreach (String word in rows)
            {
                words.Add(word);
            }
        }

    }
    catch (Exception e)
    {
        System.Windows.MessageBox.Show(e.Message);
    }

        return words;
}

answered Mar 18, 2011 at 16:33

user153923

2 Comments

Brian Over a year ago

+0: This will work, but just calling AddRange is cleaner than a foreach.

user153923 Over a year ago

I agree, but if the OP needs to see a way to exclude certain words, this would let him see where to add a piece of code to test before inserting.

Collectives™ on Stack Overflow

C# Cannot convert from string [] to string

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related