refactoring function with different methods - javascript

Question

This function current takes in an array, and outputs it a character with its count if the element's length is greater than one

Is there a way I can do this same thing, perhaps with a different javascript array method without having to use a new array or a result variable?

const a = ['aaa', 'z', 'eeeee'];

const compressCharacters = arr => {
  let newArray = [];

  let result = arr.forEach(e => e.length > 1 ? newArray.push(`${e[0]}${e.length}`) : newArray.push(e))

  return newArray.join("");
}

console.log(compressCharacters(a));

Mark · Accepted Answer · 2018-11-13 01:17:37Z

1

You can just use map() instead of forEach() and return the values you want. There's no need for the extra array. It's often the case than forEach + push() == map()

const a = ['aaa', 'z', 'eeeee'];

const compressCharacters = arr => {
  return arr.map(e => e.length > 1
           ? `${e[0]}${e.length}` 
           : e)
           .join("");
}

console.log(compressCharacters(a));

answered Nov 13, 2018 at 1:17

Mark

92.6k8 gold badges116 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

CertainPerformance · Accepted Answer · 2018-11-13 01:18:26Z

1

You can construct and immediately return a mapped array, that's joined by the empty string:

const a = ['aaa', 'z', 'eeeee'];
const compressCharacters = arr => (
  arr.map(str => str[0] + (str.length > 1 ? str.length : ''))
    .join('')
)

console.log(compressCharacters(a));

When you're trying to construct a new array by transforming all elements from some other array, .map is the appropriate method to use. forEach should be reserved for generic iteration with side effects, when you aren't trying to construct a new object. (when you are trying to construct a new object, but it's not an array, or the new array isn't one-to-one with the old array, usually you can use .reduce)

answered Nov 13, 2018 at 1:18

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Comments

Ele · Accepted Answer · 2018-11-13 02:13:58Z

1

This is an alternative using the function reduce to build the desired output.

const a = ['aaa', 'z', 'eeeee'],
      result = a.reduce((a, [m], i, arr) => {
        let {length} = arr[i];
        return a + m + (length <= 1 ? "" : length);
      }, "");

console.log(result);

edited Nov 13, 2018 at 2:13

answered Nov 13, 2018 at 1:29

Ele

33.8k7 gold badges43 silver badges80 bronze badges

1 Comment

totalnoob Over a year ago

can you explain how this works? I've never used an array in the reduce method before or deconstructed the length of an array like that before

Collectives™ on Stack Overflow

refactoring function with different methods - javascript

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related