default value for a variable in bash script

Question

I want to give my variable in bash script a default value.

Here is the script :

unamestr=`uname`
if [[ "$unamestr" == 'Linux' ]] || [[ "$unamestr" == 'Darwin' ]]; then
  DEFAULT_LOCATION="/home/$USER/.kaggle/competitions/$1"
elif [[ "$unamestr" == 'CYGWIN' ]] || [[ "$unamestr" == 'MINGW' ]]; then
  DEFAULT_LOCATION="C:\\Users\\$USER\\.kaggle\\competitions\\$1"
fi

kaggle competitions download -c $1
KAGGLE_LOCATION=${2:-DEFAULT_LOCATION}

mv KAGGLE_LOCATION .
mkdir data
mv $1/*.zip data/
mv $1/*.csv data/

cd data/
unzip *.zip
rm *.zip

When I do echo $DEFAULT_LOCATION, the correct value comes up. But when I do $KAGGLE_LOCATION and dont enter any cmd argument, I get DEFAULT_LOCATION as output instead of the actual value. What is wrong with my code?

PS: I have never used a Mac, so I am not sure if location is same for unix as Mac. If its different, please comment.

You aren't expanding the values like you should be: KAGGLE_LOCATION=${2:-$DEFAULT_LOCAITON} and mv "$KAGGLE_LOCATION" .. — chepner
– chepner, Commented May 5, 2018 at 13:27

Eby Jacob · Accepted Answer · 2018-05-05 16:17:22Z

1

You are not expanding the variable, try expanding the variable like "$KAGGLE_LOCATION"

unamestr=`uname`
if [[ "$unamestr" == 'Linux' ]] || [[ "$unamestr" == 'Darwin' ]]; then
  DEFAULT_LOCATION="/home/$USER/.kaggle/competitions/$1"
elif [[ "$unamestr" == 'CYGWIN' ]] || [[ "$unamestr" == 'MINGW' ]];then
  DEFAULT_LOCATION="C:\\Users\\$USER\\.kaggle\\competitions\\$1"
fi

kaggle competitions download -c $1
KAGGLE_LOCATION=${2:-DEFAULT_LOCATION}

mv "$KAGGLE_LOCATION" .
mkdir data
mv $1/*.zip data/
mv $1/*.csv data/

cd data/
unzip *.zip
rm *.zip

answered May 5, 2018 at 16:17

Eby Jacob

1,4681 gold badge13 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gordon Davisson Over a year ago

Similarly, you need a $ in front of DEFAULT_LOCATION when assigning to KAGGLE_LOCATION.

Collectives™ on Stack Overflow

default value for a variable in bash script

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related