Adding items from a while loop to an ArrayList java

Question

Simple one here, I have connected to a sqldb and from my database I am retrieving rows from a table.

For each row i wish to save the data to an ArrayList. Each row being an item in the ArrayList.

This is what I have so far.

List<DVDProperty> DVDList = new ArrayList<DVDProperty>();

DVDProperty context = new DVDProperty();

while (res.next()) {
    int i = res.getInt("idnew_table");
    String s = res.getString("dvdName");

    context.setDVDId(i);
    context.setDVDName(s);

    DVDList.add(context);
}

DVDPropery is a set property where i set the properties with the table row values.

I have 2 rows with the following data

1 Scarface
2 Avatar

Everytime I Run through the loop my ArrayList overrides 1 Scarface with 2 Avatar twice

I wish to add a new row to my ArrayList each time and it not override

Bozho · Accepted Answer · 2011-01-02 22:07:18Z

12

Instantiate DVDProperty inside the loop. Currently you are reusing the same instance, and thus overriding its properties:

while (res.next()) {
   DVDProperty context = new DVDProperty();
   ...
}

edited Jan 2, 2011 at 22:07

answered Jan 2, 2011 at 21:58

Bozho

599k147 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Karol Lewandowski · Accepted Answer · 2011-01-02 22:01:56Z

6

You have to create new object of type DVDProperty for every record. At this time you change the same object (context) in every iteration. Try:

List<DVDProperty> DVDList = new ArrayList<DVDProperty>();
while (res.next()) {
    int i = res.getInt("idnew_table");
    String s = res.getString("dvdName");
    DVDProperty context = new DVDProperty();
    context.setDVDId(i);
    context.setDVDName(s);
    DVDList.add(context);
}

answered Jan 2, 2011 at 22:01

Karol Lewandowski

9869 silver badges22 bronze badges

Comments

karan shah · Accepted Answer · 2015-05-26 13:28:01Z

0

Please create new instance of the DVDProperty object in loop everytime it runs the loop.
Please refer to code snippet below.

Code
List<DVDProperty> DVDList = new ArrayList<DVDProperty>();
DVDProperty context = null;
while (res.next()) {
    int i = res.getInt("idnew_table");
    String s = res.getString("dvdName");
    context = new DVDProperty();
    context.setDVDId(i);
    context.setDVDName(s);
    DVDList.add(context);
}

answered May 26, 2015 at 13:28

karan shah

775 bronze badges

Collectives™ on Stack Overflow

Adding items from a while loop to an ArrayList java

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related