push method in a loop causing array inside of array

Question

I have two arrays, one full of links and another one of domains of which shall be removed from the first array.

array1 = [ http://www.linkone.com, https://www.linktwo.com, ... ]
array2 = [ 'linkone' ]

The second array does not have the format of a URL, I've done this by doing the following:

for (let a2 of array2) {
  clearedUrls.push(_.pull(array1, `https?:\/\/www.${a2}.*`))
}

It worked, but the output of clearedUrls contains array inside of array:

[
  'https://www.foo.com',
  'https://www.foo.com',
  'https://www.foo.com',
  'https://www.foo.com',
  [
    'https://www.foo.com',
    'https://www.foo.com',
    'https://www.foo.com',
  ],
  [ ... ]
]

I know it's because every iteration it will push. I'd like to know a better way to loop over the array2, remove the URLs from array, and return the array with only links inside, no more arrays.

Useless Code · Accepted Answer · 2017-05-08 10:53:35Z

2

You should use concat instead of push:

clearedUrls = clearedUrls.concat(_.pull(array1, `https?:\/\/www.${a2}.*`))

edited May 8, 2017 at 10:53

Useless Code

12.5k5 gold badges37 silver badges42 bronze badges

answered May 8, 2017 at 10:26

Konamiman

50.5k17 gold badges111 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

push method in a loop causing array inside of array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related