Problems with pushing object into array CSS | JS | HTML

Question

Im creating a module where information (exam information) is stored in an array, and passed through to another js using localstorage. The problem i get is the previous exam always gets overwritten even though i am using .push. All the variables are defined elsewhere. Thanks for the help. Here is the code:

recentexamdb = []
document.getElementById("button1").onclick = function () {
    window.scrollTo(0, 0);
    document.getElementById("maindiv").style.visibility = "hidden";
    document.getElementById("buttondiv").style.visibility = "hidden";
    document.getElementById("countdown").style.visibility= "visible";
    var yearinput = document.getElementById("yearinput").value;
    var minuteinput = document.getElementById("minuteinput").value;
    var hourinput = document.getElementById("hourinput").value;
    var secondinput = document.getElementById("secondinput").value;
    var twentyminutes = new Audio('20mins.mp3');
    var tenminutes = new Audio('10mins.mp3');
    var fiveminutes = new Audio('5mins.mp3');
    var timesup = new Audio('timesup.mp3');
    var firstalert = document.getElementById("firstalertinput").value;
    var secondalert = document.getElementById("secondalertinput").value;
    var thirdalert = document.getElementById("thirdalertinput").value;
    var readingalert = document.getElementById("readingalertinput").value;
    var timetotal = (Number(hourinput)*60) + Number(minuteinput)
    enddate = (new Date().getTime()) + (minuteinput*60000) +(secondinput*1000) + (hourinput*3600000);
    var examtypeinput = document.getElementById("examtypeinput").value;
    var hours=0;
    var minutes=0;
    var seconds=0;
    var countdown = document.getElementById("countdown");
    var examtype = document.getElementById("examtype");

 setInterval(function () {
        var currentdate = new Date().getTime();
        var secondsleft = (enddate - currentdate) / 1000;
        // do some time calculations
        hours = parseInt(secondsleft / 3600);
        secondsleft = secondsleft % 3600;
        minutes = parseInt(secondsleft / 60);
        seconds = parseInt(secondsleft % 60);
        if (hours == 0 && minutes == 0 && seconds == 0) {
          document.getElementById("countdowndiv").style.fontFamily = "Helvetica Neue, Arial, sans-serif"
          document.getElementById("countdowndiv").style.fontSize = "100%"
          countdown.innerHTML = "Time is up! Pens down and wait for further instruction"
          examtype.innerHTML = "If you continue to write, marks may be deducted"
          var readingtimenow = "No reading time selected"
          var timetotalnow = ((hours * 60) + minutes)
          var examinfoobject = {
            year: yearinput,
            examtime: timetotalnow,
            timeofexam: Date(),
            examtype: examtypeinput,
            readingtime: readingtimenow
          }
          recentexamdb.push(examinfoobject)
          console.log(recentexamdb)
          localStorage.setItem("storedexamdb", JSON.stringify(recentexamdb))
      }
}, 1000);
}

Please provide the whole relevant code.

Mr_Green
– Mr_Green

2016-07-04 06:58:13 +00:00
Commented Jul 4, 2016 at 6:58 — Mr_Green
– Mr_Green, Commented Jul 4, 2016 at 6:58
Have you declared recentexamdb as an array?

rrd
– rrd

2016-07-04 07:07:16 +00:00
Commented Jul 4, 2016 at 7:07 — rrd
– rrd, Commented Jul 4, 2016 at 7:07
Added rest of code

maxphat
– maxphat

2016-07-04 07:21:21 +00:00
Commented Jul 4, 2016 at 7:21 — maxphat
– maxphat, Commented Jul 4, 2016 at 7:21
can you create a fiddle please

Susheel Singh
– Susheel Singh

2016-07-04 14:14:38 +00:00
Commented Jul 4, 2016 at 14:14 — Susheel Singh
– Susheel Singh, Commented Jul 4, 2016 at 14:14

Aarati · Accepted Answer · 2016-07-04 14:29:16Z

1

Correcting the syntax specific to JS, (thanks for pointing out) First initialize the "recentexamdb" from existing value in local storage, otherwise it will always be a new array & earlier saved values may be lost.

recentexamdb=JSON.parse(localStorage.getItem("storedexamdb")); // read  already saved values
 recentexamdb.push(examinfoobject);
 localStorage.setItem("storedexamdb",JSON.stringify(recentexamdb));

On next page, you can Hope this helps.

edited Jul 4, 2016 at 14:29

answered Jul 4, 2016 at 14:12

Aarati

3211 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Susheel Singh Over a year ago

why are you giving angular answer ? it is javascript question

maxphat Over a year ago

Doesnt seem to work. I added it like stated after the examinfoobject, and declared the variable at the start of the project. I get this error : timermodule.js:319 Uncaught TypeError: Cannot read property 'push' of null. line 319 was at recentexamdb.push(examinfoobject)

maxphat · Accepted Answer · 2016-07-05 01:41:26Z

0

Fixed due to aarati's answer. It worked when i set a localstorage clickcounter and only used the already saved values when the clickcounter was >1

answered Jul 5, 2016 at 1:41

maxphat

375 bronze badges

Collectives™ on Stack Overflow

Problems with pushing object into array CSS | JS | HTML

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related