Find missing numbers in JavaScript array

Question

I am writing this code to find missing numbers from a given array. This code works fine when i pass 1,4 as arguments but 5,10 it fails to push new items to the array. What am I doing wrong?

 function sumAll(arr) {
   max = Math.max(...arr);
   min = Math.min(...arr);
   toFill = max - min;
   for (i = min + 1; i <= toFill; i++) {
     arr.push(i);
   }
   return arr.sort().reduce((prev, curr) => prev + curr);

 }

 sumAll([5, 10]);

I think i immediately found my problem. if my min is equal to my 'toFill' my for loop will not run... makes sense now. Will look into it further and post an update. — Josh Lavely
– Josh Lavely, Commented Jun 13, 2016 at 15:22
I didnt find the solution, i found a problem that may help find the solution. — Josh Lavely
– Josh Lavely, Commented Jun 13, 2016 at 15:35

JoshBerke · Accepted Answer · 2016-06-13 15:28:35Z

1

You need to say i <= min+toFill

function sumAll(arr) {
   max = Math.max(...arr);
   min = Math.min(...arr);
   toFill = max - min;
   for (i = min + 1; i <= min+toFill; i++) { console.log(i);
     arr.push(i);
   }
   return arr.sort().reduce((prev, curr) => prev + curr);

 }

answered Jun 13, 2016 at 15:28

JoshBerke

67.3k25 gold badges131 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Josh Lavely Over a year ago

I had to get rid of += in my for loop. for(i = min +1; i < min+toFill; i++)

Collectives™ on Stack Overflow

Find missing numbers in JavaScript array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related