How to check if we have error using angularJs $http method?

Question

I am using angularJs factory its making call and working as expected but in terms of exception i have question what if we have exception after making call and it fails so in this case when i execute prcDeleteFactory.deletePrcInventory i want to check first if there is any error display error and stay on same page.

How can i resolve this problem using below code ?

ctrl.js

 function deleteInventory(inventory,controlId) {
      prcDeleteFactory.deletePrcInventory(inventory,controlId).then(function(){
        $scope.confirmationWin.close();
        $state.go('app.search');
      });
    }

factory.js

angular.module('App').factory('prcDeleteFactory',function($http){
  'use strict';
  return {
    deletePrcInventory: function(inventoryToDelete,key){
      return $http.get('app/delete/deleteInventory?inventoryToDelete=' + inventoryToDelete + '&key=' + key);
    }
  };
});

dfsq · Accepted Answer · 2016-03-16 20:26:53Z

2

You need to "catch" error. If it happens promised returned by $http service gets rejected so you can handle it with catch (or error callback in then):

function deleteInventory(inventory,controlId) {
  prcDeleteFactory.deletePrcInventory(inventory, controlId).then(function() {
    $scope.confirmationWin.close();
    $state.go('app.search');
  })
  .catch(function(error) {
    $scope.error = 'Delete failed.';
  });
}

edited Mar 16, 2016 at 20:26

answered Mar 16, 2016 at 20:25

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

hussain Over a year ago

How about if we have error message from server that we need to display in case of failure ?

Lex Over a year ago

There is also the option to have a second function parameter inside .then() to handle situations where your server-side code runs and returns an error.

dfsq Over a year ago

@hussain You could set some error message on the scope.

Lex Over a year ago

Maybe @hussain is unaware that the standard form of .then() is .then(function successCallback(result){}, function errorCallback(error){}); You might consider adding that to your answer for completeness' sake.

dfsq Over a year ago

@Lex I briefly mentioned it too, but anyway I wouldn't recommend error callback simply because it won't catch errors if they happen in the sibling success handler.

|

cl3m · Accepted Answer · 2016-03-16 20:29:51Z

0

What about using the then / catch form :

 $http.get(/**/).then(function(response) {
    // do something with response
 }).catch(function(err) {
    // do something with error err
 })

answered Mar 16, 2016 at 20:29

cl3m

2,80121 silver badges21 bronze badges

Comments

henrikmerlander · Accepted Answer · 2016-03-16 21:22:44Z

0

The second parameter for .then()is the function that executes on error. Change your controller code to:

function deleteInventory(inventory,controlId) {
    prcDeleteFactory.deletePrcInventory(inventory,controlId).then(function(){
        $scope.confirmationWin.close();
        $state.go('app.search');
    }, function(error){
        //Some error occurred here
  });
}

answered Mar 16, 2016 at 21:22

henrikmerlander

1,58413 silver badges20 bronze badges

Collectives™ on Stack Overflow

How to check if we have error using angularJs $http method?

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related