Select an html element created with JS in JS

Question

I need to create a h1 element using JavaScript and then add a content to that h1. This is what I tried:

<div id="time">
</div>
<script>
  var h1 = document.getElementById("time").createElement("h1");
  h1.id= "timeh1";
  document.getElementById("timeh1").innerHTML = "Good Afternoon!";
</script>

and

<div id="time>
</div>
<script>
  document.getElementById("time").createElement("h1");
  document.getElementByTagName("h1")[0].setAttribute("id", "time-h1");
  document.getElementById("time-h1").innerHTML = "Good Afternoon!";
</script>

and

document.getElementById("time").createElement("h1").innerHTML = "Good Afternoon!";

jered · Accepted Answer · 2016-02-11 21:25:16Z

3

You can't use document.getElementById() to get an element unless it has been added to the DOM, which it hasn't been in any of your examples. That being said, you don't need to add the element to the DOM to change its innerHTML, since you already have a reference to it in JS by virtue of creating it.

Either do this:

var h1 = document.createElement("h1");
h1.id= "timeh1";
h1.innerHTML = "Good Afternoon!";

Or this:

var h1 = document.createElement("h1");
h1.id= "timeh1";
document.getElementById("time").appendChild(h1);
document.getElementById("timeh1").innerHTML = "Good Afternoon!";

edited Feb 11, 2016 at 21:25

answered Feb 11, 2016 at 20:27

jered

11.6k2 gold badges26 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Shniper Over a year ago

So I was pretty much over complicating it. Thanks

traktor Over a year ago

You may wish to test first: createElement is a method of document, not HTML element nodes.

jered Over a year ago

Good point, I just copied his code and added some without checking it over too closely.

IrkenInvader · Accepted Answer · 2016-02-11 20:23:51Z

2

Here I am creating the element, then setting the text.

From there you can append the new element to your 'time' div.

var h1 = document.createElement('h1');
h1.innerHtml = "Good Afternoon!";

document.getElementById('time').appendChild(h1);

answered Feb 11, 2016 at 20:23

IrkenInvader

4,0401 gold badge14 silver badges25 bronze badges

1 Comment

traktor Over a year ago

If you want to replace existing content of #time, you can set its innerHTML to "" (null string) first.

Failwyn · Accepted Answer · 2016-02-11 20:26:41Z

1

You have to add it to the DOM before you can use getElementById to find it.

var b = document.createElement('button');
document.body.appendChild(b);

answered Feb 11, 2016 at 20:26

Failwyn

81710 silver badges25 bronze badges

Comments

jeerbl · Accepted Answer · 2016-02-11 20:27:07Z

1

You need to create your element first:

var h1 = document.createElement("h1");
h1.innerHTML = "Good Afternoon!";

Then, after the h1 element is created, you can append it to your div:

document.getElementById("time").appendChild(h1);

answered Feb 11, 2016 at 20:27

jeerbl

7,9675 gold badges28 silver badges39 bronze badges

Comments

Nikita Kurtin · Accepted Answer · 2016-02-12 09:27:37Z

1

use appendChild method to add created h1 to particular element at the document. For example to body like this:

var h1 = document.createElement("h1");
h1.id= "timeh1";
h1.textContent="Good afternoon";
document.body.appendChild(h1);//append dynamically created h1 at the end of the body

Extra tip: for this case .textContent is better instead of innerHTML. since adding content is only textual. Here is a good reference for usage of this property: textContent

edited Feb 12, 2016 at 9:27

answered Feb 11, 2016 at 20:25

Nikita Kurtin

6,2554 gold badges48 silver badges49 bronze badges

Comments

traktor · Accepted Answer · 2016-02-11 20:59:32Z

0

You could create and add the header using innerHTML markup:

document.getElmentById("time").innerHTML = "<h1>Good Afternoon!</h1>";

Or use document.createElement to create the header node, insert its content using innerHTML (say) and insert it into the DOM.

var h1 = document.createElement("h1");
h1.innerHTML =  "Godd Afternoon!";
var container = document.getElementById("time");
container.innerHTML = "";  // reset contents of #time div to nothing
container.appendChild(h1);

Resetting the contents of the div works to replace existing content (if there is none, the reset is not required).

answered Feb 11, 2016 at 20:59

traktor

19.7k5 gold badges37 silver badges56 bronze badges

Collectives™ on Stack Overflow

Select an html element created with JS in JS

6 Answers 6

3 Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

3 Comments

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related