Displaying List Of JavaScript Objects As HTML List Items

Question

When I attempt this, the HMTL page only displays the last object, instead of all the objects.

Here is my JavaScript file

var family = {
  aaron: {
    name: 'Aaron',
    age: 30
  },
  megan: {
    name: 'Megan',
    age: 40
  },
  aaliyah: {
    name: 'Aaliyah',
    age: 2
  }
}

var list = function(family) {
  for (var prop in family) {
    var elList = document.getElementById('aaron-family').innerHTML = prop;
  }
}

list(family);

And here's my HTML file

<html>
<head>
  <title>Aaron's Test With Objects</title>
</head>
  <li id="aaron-family">Hey, this is where it goes</li>
<footer>
  <script src="objects.js"></script>
</footer>
</html>

You need to append new items to the list.

PM 77-1
– PM 77-1

2016-01-31 00:13:29 +00:00
Commented Jan 31, 2016 at 0:13 — PM 77-1
– PM 77-1, Commented Jan 31, 2016 at 0:13

Aaron Kantrowitz · Accepted Answer · 2016-01-31 00:29:55Z

7

Thank you guys! Here's the final solution I came up with:

JS

var family = {
  aaron: {
    name: 'Aaron',
    age: 30
  },
  megan: {
    name: 'Megan',
    age: 40
  },
  aaliyah: {
    name: 'Aaliyah',
    age: 2
  }
}

var list = function(family) {
  for (var prop in family) {
    document.getElementById('aaron-family').innerHTML += '<li>' + prop + '</li>';
    console.log(prop);
  }
}

HTML

<html>
<head>
  <title>Aaron's Test With Objects</title>
</head>
<ul id="aaron-family">
</ul>
<footer>
  <script src="objects.js"></script>
</footer>
</html>

I'm sure it can be refactored but it works, visually.

answered Jan 31, 2016 at 0:29

Aaron Kantrowitz

1011 gold badge1 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tkellehe Over a year ago

You might want to move the document.getElementById outside of the for loop because each loop you are doing a query for that id:)

sfletche · Accepted Answer · 2016-01-31 00:14:13Z

3

Well, you've got a couple problems there (<li> tag without a parent <ol> or <ul> tag, among others)...but I'd say the primary error is that you are replacing each subsequent output with each assignment to innerHTML.

Solution: assign a compiled array to innerHTML (using join to include spaces between the values)

var list = function(family) {
  var names = [];
  for (var prop in family) {
    names.push(prop.name);
  }
  document.getElementById('aaron-family').innerHTML = names.join(' ');
}
list(family);

answered Jan 31, 2016 at 0:14

sfletche

50.1k32 gold badges110 silver badges120 bronze badges

Comments

tkellehe · Accepted Answer · 2016-01-31 00:18:09Z

1

Remove elList because there is no point in having it...

Then change

document.getElementById('aaron-family').innerHTML = prop;

To

document.getElementById('aaron-family').innerHTML += prop;

That way you are not constantly setting the innherHTML to prop. Also, you might find it better to change the function to the following in order to prevent from constantly getting the element.

function list(family) {
  var elList = document.getElementById('aaron-family');
  for (var prop in family) {
    elList.innerHTML += prop;
  }
}

Hope this helps:)

answered Jan 31, 2016 at 0:18

tkellehe

6695 silver badges11 bronze badges

Comments

Mohammed · Accepted Answer · 2019-01-05 23:26:11Z

1

This dynamic way to render like this data format into HTML

const elList = document.getElementById('aaron-family')

function convertObjectsToArrayOfObjects(family) {
    const filteredData = []
    for(person in family){
          filteredData.push(family[person])
     }
    return filteredData;
 }

function elList(family) {
   const familyData = convertObjectsToArrayOfObjects(family)
   elList.innerHTML = `
      ${
        familyData.map(person => {
          return `
            <h1>name: ${person.name}</h1>
            <h2>age: ${person.age}</h2>
          `   
       })
     }
  `
}

list(family);

answered Jan 5, 2019 at 23:26

Mohammed

2113 silver badges3 bronze badges

Comments

Ebrahim Amini Sharifi · Accepted Answer · 2019-05-11 10:50:58Z

0

Just you don't need to define function

html file:

var family = {
    aaron: {
        name: 'Aaron',
        age: 30
    },
    megan: {
        name: 'Megan',
        age: 40
    },
    aaliyah: {
        name: 'Aaliyah',
        age: 2
    }
}

for (var prop in family) {

    document.getElementById('aaron-family').innerHTML += '<li>' + prop + '</li>';

}

<html>
    <head>
        <title>Aaron's Test With Objects</title>
    </head>
    <body>

        <ul id="aaron-family">
        </ul>
        <script src="objects.js" type="text/javascript"></script>

    </body>
</html>

answered May 11, 2019 at 10:50

Ebrahim Amini Sharifi

1,00412 silver badges29 bronze badges

Collectives™ on Stack Overflow

Displaying List Of JavaScript Objects As HTML List Items

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related