Javascript Replace text in string

Question

I'm having some troubles getting regex to replace all occurances of a string within a string.

**What to replace:**
href="/newsroom

**Replace with this:**
href="http://intranet/newsroom

This isn't working:

str.replace(/href="/newsroom/g, 'href="http://intranet/newsroom"');

Any ideas?

EDIT

My code:

str = '<A href="/newsroom/some_image.jpg">photo</A>';
str = str.replace('/href="/newsroom/g', 'href="http://intranet/newsroom"');
document.write(str);

Thanks, Tegan

I'm not sure if you copied it correcly, but you have missed the single quotation marks in the first string. it should be str.replace('/href="/newsroom/g', 'href="http://intranet/newsroom"'); — Thea
– Thea, Commented Jun 17, 2010 at 19:59
Wierd it doesnt work for me: str = str.replace('/href="/newsroom/g', 'href="intranet/newsroom"'); — Tegan Snyder
– Tegan Snyder, Commented Jun 17, 2010 at 20:12

Mark Byers · Accepted Answer · 2010-06-17 20:25:17Z

3

Three things:

You need to assign the result back to the variable otherwise the result is simply discarded.
You need to escape the slash in the regular expression.
You don't want the final double-quote in the replacement string.

Try this instead:

str = str.replace(/href="\/newsroom/g, 'href="http://intranet/newsroom')

Result:

<A href="http://intranet/newsroom/some_image.jpg">photo</A>

edited Jun 17, 2010 at 20:25

answered Jun 17, 2010 at 19:59

Mark Byers

844k202 gold badges1.6k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Robusto · Accepted Answer · 2010-06-17 19:59:43Z

2

You need to escape the forward slash, like so:

str.replace(/href="\/newsroom\/g, 'href=\"http://intranet/newsroom\"');

Note that I also escaped the quotes in your replacement argument.

answered Jun 17, 2010 at 19:59

Robusto

32k8 gold badges59 silver badges79 bronze badges

2 Comments

Robusto Over a year ago

And, as @Mark Byers points out, you need to assign the result to str :)

Tegan Snyder Over a year ago

syntax highlighting in dreamweaver isn't liking it: str = str.replace(/href="\/newsroom\/g, 'href=\"intranet/newsroom\"');

Thea · Accepted Answer · 2010-06-17 22:10:27Z

1

This should work

 str.replace(/href="\/newsroom/g, 'href=\"http://intranet/newsroom\"')

UPDATE:
This will replase only the given string:

str = '<A href="/newsroom/some_image.jpg">photo</A>';
str = str.replace(/\/newsroom/g, 'http://intranet/newsroom');
document.write(str);

edited Jun 17, 2010 at 22:10

answered Jun 17, 2010 at 20:19

Thea

8,0656 gold badges30 silver badges41 bronze badges

2 Comments

Tegan Snyder Over a year ago

it works but doesn't leave the image name on the end of the url [code] <script> str = '<A href="/newsroom/some_image.jpg">photo</A>'; str = str.replace(/href="\/newsroom/g, 'href=\"intranet/newsroom\"'); document.write(str); </script> [code]

Tegan Snyder Over a year ago

still only getting me a link called photo that goes to intranet/newsroom when it should go to intranet/newsroom/some_image.jpg <code> <script> str = '<A href="/newsroom/some_image.jpg">photo</A>'; str = str.replace(/href="\/newsroom/g, 'href=\"intranet/newsroom\"'); document.write(str); </script> </code>

Collectives™ on Stack Overflow

Javascript Replace text in string

EDIT

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

EDIT

3 Answers 3

Comments

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related