Populate bidimensional array with single array in java

Question

how do I populate a matrix in java with a array without using libs?

I have this method

public static String[][] transformArray(String msg, int slice) {
    String matrix[][] = new String[slice][msg.length() / slice];

    String[] msgArray= mensagem.split("");


        for (int j = 0; j < matrix.length; j++) {
            for (int h = 0; h < matrix[j].length; h++) {
                for (int i = 0; i < matrix.length(); i++ ) {
                    matrix[j][h] = msgArray[i];
            }
        }
    }


    return matrix;
}

And when I call:

String anotherMatrix = transformArray("Java is cool", 2);

My return is this (i have a method to print a matrix):

 l l l l l l 
 l l l l l l

What I'm doing wrong?

Paul Boddington · Accepted Answer · 2015-04-05 18:53:15Z

1

I assume you want this

int i = 0;
for (int j = 0; j < matrix.length; j++) {
    for (int h = 0; h < matrix[j].length; h++) {
        matrix[j][h] = msgArray[i++];
    }
}

You should not use 3 loops. What is happening with your code is that for each j and h, the matrix entry is being replaced with every character in turn, so every entry is ending up with the l from cool. There should not be a loop for each entry as you only want one character.

answered Apr 5, 2015 at 18:53

Paul Boddington

37.8k10 gold badges69 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juxhin · Accepted Answer · 2015-04-05 18:54:11Z

0

In order to access every element within your 2D-array you would have to iterate like so:

for(int i=0 ; i<n ; i++) {
    for(int j=0; j<n ; j++) {
        myArray[i][j] = inc;
        inc++;
    }
}

You instead are using three for-loops which is incorrect. Try adjusting your code to follow this set up, it's really easy. Edit: pbabcdefp has already done that for you!

answered Apr 5, 2015 at 18:54

Juxhin

5,7109 gold badges34 silver badges59 bronze badges

Collectives™ on Stack Overflow

Populate bidimensional array with single array in java

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related