ASP.NET MVC Html.ValidationSummary(true) does not display model errors

Question

I have some problem with Html.ValidationSummary. I don't want to display property errors in ValidationSummary. And when I set Html.ValidationSummary(true) it does not display error messages from ModelState. When there is some Exception in controller action on string

MembersManager.RegisterMember(member);

catch section adds an error to the ModelState:

ModelState.AddModelError("error", ex.Message);

But ValidationSummary does not display this error message. When I set Html.ValidationSummary(false) all messages are displaying, but I don't want to display property errors. How can I fix this problem?

Here is the code I'm using:

Model:

public class Member
{
        [Required(ErrorMessage = "*")]
        [DisplayName("Login:")]
        public string Login { get; set; }

        [Required(ErrorMessage = "*")]
        [DataType(DataType.Password)]
        [DisplayName("Password:")]
        public string Password { get; set; }

        [Required(ErrorMessage = "*")]
        [DataType(DataType.Password)]
        [DisplayName("Confirm Password:")]
        public string ConfirmPassword { get; set; }
}

Controller:

[HttpPost]
public ActionResult Register(Member member)
{
    try
    {
        if (!ModelState.IsValid)
            return View();

        MembersManager.RegisterMember(member);
    }
    catch (Exception ex)
    {
        ModelState.AddModelError("error", ex.Message);

        return View(member);
    }
}

View:

<% using (Html.BeginForm("Register", "Members", FormMethod.Post, 
                        new { enctype = "multipart/form-data" })) {%> 
    <p>
        <%= Html.LabelFor(model => model.Login)%>
        <%= Html.TextBoxFor(model => model.Login)%>
        <%= Html.ValidationMessageFor(model => model.Login)%>
    </p>

    <p>
        <%= Html.LabelFor(model => model.Password)%>
        <%= Html.PasswordFor(model => model.Password)%>
        <%= Html.ValidationMessageFor(model => model.Password)%>
    </p>

    <p>
        <%= Html.LabelFor(model => model.ConfirmPassword)%>
        <%= Html.PasswordFor(model => model.ConfirmPassword)%>
        <%= Html.ValidationMessageFor(model => model.ConfirmPassword)%>
    </p>

    <div>
        <input type="submit" value="Create" />
    </div>

    <%= Html.ValidationSummary(true)%>
<% } %>

JTech · Accepted Answer · 2019-03-19 02:22:20Z

334

I believe the way the ValidationSummary flag works is it will only display ModelErrors for string.empty as the key. Otherwise it is assumed it is a property error. The custom error you're adding has the key 'error' so it will not display in when you call ValidationSummary(true). You need to add your custom error message with an empty key like this:

ModelState.AddModelError(string.Empty, ex.Message);

edited Mar 19, 2019 at 2:22

JTech

3,5808 gold badges47 silver badges54 bronze badges

answered May 12, 2010 at 13:26

Jab

13.8k2 gold badges45 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Daniel Schaffer Over a year ago

@LordCover: I'm guessing this is "working as designed" and not a bug - the overload of ValidationSummary() used by default excludes ModelState errors associated with the properties of the model itself. This leaves those errors to be represented by Html.ValidationMessageFor() calls for each individual property without having them duplicated in the summary. That in mind, it appears that any model error added with a non-empty key is assumed to be associated with a model property, even if the key doesn't match the name of a property.

wolfyuk Over a year ago

Just a note for other implementers: ModelState.AddModelError(string.Empty, ex); doesn't seem to work either. You must use the ModelState.AddModelError(string, string) overload as shown above.

Neil Thompson Over a year ago

update: In MVC4 this no longer seems to be the case. ModelState.AddModelError("", ex.Message); works

smiggleworth Over a year ago

MVC5 I still needed to call the ex.Message to get it to work.

sairfan Over a year ago

first parameter to ValidationSummary methos is excludePropertyErrors set it to fase it will start showing model errors, otherwise setting key parameter of AddModelErros method to string.empty will show custom error messages.

ingvesund · Accepted Answer · 2013-02-27 11:55:01Z

70

This works better, as you can show validationMessage for a specified key:

    ModelState.AddModelError("keyName","Message");

and display it like this:

    @Html.ValidationMessage("keyName")

answered Feb 27, 2013 at 11:55

ingvesund

8016 silver badges5 bronze badges

Comments

Levitikon · Accepted Answer · 2013-11-13 22:50:15Z

29

I know this is kind of old and has been marked as answers with 147 up votes, but there is something else to consider.

You can have all the model errors, the property named and string.Empty keys alike, be shown in the ValidationSummary if you need to. There is an overload in the ValidationSummary that will do this.

    //   excludePropertyErrors:
    //   true to have the summary display model-level errors only, or false to have
    //   the summary display all errors.
    public static MvcHtmlString ValidationSummary(this HtmlHelper htmlHelper, bool excludePropertyErrors);

enter image description here

answered Nov 13, 2013 at 22:50

Levitikon

7,9079 gold badges60 silver badges74 bronze badges

1 Comment

Mikhail Aksenov Over a year ago

Yes! Just change @Html.ValidationSummary(true, "", new { @class = "text-danger" }) to @Html.ValidationSummary(false, "", new { @class = "text-danger" })

Steven V · Accepted Answer · 2014-11-02 18:30:05Z

9

Maybe like that:

[HttpPost]
public ActionResult Register(Member member)
{
    try
    {
       if (!ModelState.IsValid)
       {
          ModelState.AddModelError("keyName", "Form is not valid");
          return View();
       }
       MembersManager.RegisterMember(member);
    }
    catch (Exception ex)
    {
       ModelState.AddModelError("keyName", ex.Message);
       return View(member);
    }
}

And in display add:

<div class="alert alert-danger">
  @Html.ValidationMessage("keyName")
</div>

OR

<div class="alert alert-danger">
  @Html.ValidationSummary(false)
</div>

edited Nov 2, 2014 at 18:30

Steven V

16.7k3 gold badges66 silver badges77 bronze badges

answered Oct 12, 2014 at 14:04

Piotr Knut

3503 silver badges8 bronze badges

Comments

Ali · Accepted Answer · 2018-12-31 09:45:42Z

6

@Html.ValidationSummary(false,"", new { @class = "text-danger" })

Using this line may be helpful

edited Dec 31, 2018 at 9:45

Ali

2,7643 gold badges37 silver badges61 bronze badges

answered Dec 31, 2018 at 4:43

sachind

4216 silver badges8 bronze badges

1 Comment

sachind Over a year ago

Add th above line in cshtml file.

Community · Accepted Answer · 2017-05-23 12:03:05Z

3

In my case it was not working because of the return.

Instead of using:

return RedirectToAction("Rescue", "CarteiraEtapaInvestimento", new { id = investimento.Id, idCarteiraEtapaResgate = etapaDoResgate.Id });

I used:

return View("ViewRescueCarteiraEtapaInvestimento", new CarteiraEtapaInvestimentoRescueViewModel { Investimento = investimento, ValorResgate = investimentoViewModel.ValorResgate });

It´s a Model, so it is obvius that ModelState.AddModelError("keyName","Message"); must work with a model.

This answer show why. Adding validation with DataAnnotations

edited May 23, 2017 at 12:03

CommunityBot

11 silver badge

answered Sep 27, 2014 at 23:43

Allan Patrick Patzlaff

1271 silver badge3 bronze badges

Comments

alex · Accepted Answer · 2015-05-12 20:37:03Z

0

If nearly everything seems right, another thing to look out for is to ensure that the validation summary is not being explicitly hidden via some CSS override like this:

.validation-summary-valid {
    display: none;
}

This may also cause the @Html.ValidationSummary to appear hidden, as the summary is dynamically rendered with the validation-summary-valid class.

answered May 12, 2015 at 20:37

alex

7,59812 gold badges62 silver badges116 bronze badges

Comments

Adrita Sharma · Accepted Answer · 2019-08-30 19:34:56Z

0

You can try,

<div asp-validation-summary="All" class="text-danger"></div>

answered Aug 30, 2019 at 19:34

Adrita Sharma

22.3k11 gold badges75 silver badges85 bronze badges

1 Comment

Stephen Angell Over a year ago

note - this has to be a <div>, if it's a <span> it won't render.

user10997800 · Accepted Answer · 2021-12-10 09:13:22Z

0

use can use bellow lines

    @if (!ViewData.ModelState.IsValid)
                {
                    @Html.ValidationSummary("", new { @class = "alert alert-warning alert-dismissible fade show" })
                }

and for each field use somthing like this:

                    @Html.ValidationMessageFor(m => m.Email, null, new { @class = "field-validation-error " })

answered Dec 10, 2021 at 9:13

user10997800

Comments

Robert · Accepted Answer · 2015-04-06 11:12:56Z

-5

ADD it in the lowermost part og your View:

@section Scripts { @Scripts.Render("~/bundles/jqueryval") }

edited Apr 6, 2015 at 11:12

Robert

5,31843 gold badges70 silver badges115 bronze badges

answered Apr 6, 2015 at 10:43

ronIT

1,2652 gold badges10 silver badges6 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC Html.ValidationSummary(true) does not display model errors

10 Answers 10

5 Comments

Comments

1 Comment

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

10 Answers 10

5 Comments

Comments

1 Comment

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related