NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference [duplicate]

Question

I am getting this error at runtime.

java.lang.RuntimeException: Unable to start activity ComponentInfo java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference

StackTrace:

01-12 03:44:54.270: E/AndroidRuntime(1437): FATAL EXCEPTION: main
01-12 03:44:54.270: E/AndroidRuntime(1437): Process: home.saket, PID: 1437
01-12 03:44:54.270: E/AndroidRuntime(1437): java.lang.RuntimeException: Unable to start activity ComponentInfo{home.saket/home.saket.addmember.Add_Update_User}: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2298)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2360)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread.access$800(ActivityThread.java:144)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1278)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.os.Handler.dispatchMessage(Handler.java:102)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.os.Looper.loop(Looper.java:135)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread.main(ActivityThread.java:5221)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at java.lang.reflect.Method.invoke(Native Method)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at java.lang.reflect.Method.invoke(Method.java:372)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
01-12 03:44:54.270: E/AndroidRuntime(1437): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference
01-12 03:44:54.270: E/AndroidRuntime(1437):     at home.saket.addmember.Add_Update_User.onCreate(Add_Update_User.java:38)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.Activity.performCreate(Activity.java:5933)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
01-12 03:44:54.270: E/AndroidRuntime(1437):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2251)
01-12 03:44:54.270: E/AndroidRuntime(1437):     ... 10 more
01-12 03:44:54.272: W/ActivityManager(472):   Force finishing activity home.saket/.addmember.Add_Update_User
01-12 03:44:54.273: E/ActivityManager(472): Invalid thumbnail dimensions: 384x384

Below I am posted the codes and pointed out the error line.

Add_Update_User.java:

@Override
    protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.add_update_screen);

    // set screen
    Set_Add_Update_Screen();

    // set visibility of view as per calling activity
    String called_from = getIntent().getStringExtra("called");

    if (called_from.equalsIgnoreCase("add")) {  --->38th error line
        add_view.setVisibility(View.VISIBLE);
        update_view.setVisibility(View.GONE);
    } else {

        update_view.setVisibility(View.VISIBLE);
        add_view.setVisibility(View.GONE);
        USER_ID = Integer.parseInt(getIntent().getStringExtra("USER_ID"));

        Contact c = dbHandler.Get_Contact(USER_ID);  

        add_name.setText(c.getName());
        add_mobile.setText(c.getPhoneNumber());
        add_email.setText(c.getEmail());
        // dbHandler.close();
    }
    }

can you try this for me plz? if("add".equalsIgnoreCase(called_from)){ — Kick Buttowski
– Kick Buttowski, Commented Jan 12, 2015 at 4:01
@KickButtowski I tried yours.works fine.can you post your answer and explain it? — Steve
– Steve, Commented Jan 12, 2015 at 4:07
I cannot post my answer since your post has been marked as duplicate. :( — Kick Buttowski
– Kick Buttowski, Commented Jan 12, 2015 at 4:11
Everybody told me to suggest for null check.your answer was solved me.But now you can't post your answer because it is closed.sorry for that. @KickButtowski — Steve
– Steve, Commented Jan 12, 2015 at 4:11
you may wanna see this discussion as well chat.stackoverflow.com/rooms/68625/madandi — Kick Buttowski
– Kick Buttowski, Commented Jan 12, 2015 at 5:16

Elliott Frisch · Accepted Answer · 2015-01-12 04:26:47Z

66

called_from must be null. Add a test against that condition like

if (called_from != null && called_from.equalsIgnoreCase("add")) {

or you could use Yoda conditions (per the Advantages in the linked Wikipedia article it can also solve some types of unsafe null behavior they can be described as placing the constant portion of the expression on the left side of the conditional statement)

if ("add".equalsIgnoreCase(called_from)) { // <-- safe if called_from is null

edited Jan 12, 2015 at 4:26

answered Jan 12, 2015 at 4:04

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Alex K Over a year ago

I love Yoda conditions...+1 for that idea!

Kick Buttowski Over a year ago

can you explain the Yoda Conditions here plz?

Elliott Frisch Over a year ago

@KickButtowski Edited to include some explanation.

Kick Buttowski Over a year ago

@ElliottFrisch I still do not understand how it throws NPE. how ?

Elliott Frisch Over a year ago

@Kick The Yoda conditions don't throw NPE, that is the point of using them. What are you asking?

|

Alex K · Accepted Answer · 2021-10-10 15:09:30Z

8

This is the error line:

if (called_from.equalsIgnoreCase("add")) {  --->38th error line

This means that called_from is null. Simple check if it is null before using it:

String called_from = getIntent().getStringExtra("called");

if (called_from != null && called_from.equalsIgnoreCase("add")) {
    // do whatever
} else {
    // do whatever
}

That way, if called_from is null, it'll execute the else part of your conditional.

edited Oct 10, 2021 at 15:09

answered Jan 12, 2015 at 4:03

Alex K

8,3369 gold badges43 silver badges58 bronze badges

Comments

htredleaf · Accepted Answer · 2015-01-12 04:05:42Z

4

The exception occurs due to this statement,

called_from.equalsIgnoreCase("add")

It seem that the previous statement

String called_from = getIntent().getStringExtra("called");

returned a null reference.

You can check whether the intent to start this activity contains such a key "called".

answered Jan 12, 2015 at 4:05

htredleaf

1923 silver badges10 bronze badges

Collectives™ on Stack Overflow

NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equalsIgnoreCase(java.lang.String)' on a null object reference [duplicate]

3 Answers 3

8 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

8 Comments

Comments

Comments

Linked

Related