PHP: using an html Form to call up a PHP action

Question

I am trying to create a 'submit' input type button that when clicked will call up a switch case action that I've defined in PHP. When the 'submit' button is clicked, I want the form action to essentially create a link and display in the URL form action so that it is called properly by the PHP file.

However when I click on the submit button, the URL does not properly display the desired link and action.

PHP:

$getuserid_result = mysql_query($getuseridsql, $conn);
$userid_array = mysql_fetch_array($getuserid_result);

$userid = $userid_array['uid']; 

// Above code works fine and retrieves the current user's ID

// PHP Form code is below

// Variables used for creating the id of the input since the submit button is displayed
// in an HTML table with multiple rows.  These variables are working fine.
$time_cell_row = 1;
$time_cell_column = 1;

echo "<form action='enter_time.php?uid='" . $userid . "?action=timesubmit method='get'>";  

       echo "<td><input name=submit_time type=submit id=submit_time" . $time_cell_row . $time_cell_column . "></input></td>";
       echo  "</form></tr>";

// PHP Action code

/* This is currently commented out and will eventually be filled with code to handle 
   the 'timesubmit' action 

      if (isset($_GET['action'])) { 
    switch (strtolower($_GET['action'])) {
      case 'timesubmit':



    }
   } 
      */

The problem now is when I click on the 'submit' button, the URL displayed enter_time.php?submit_time=Submit" instead of "enter_time.php?uid=3?action=timesubmit

You should consider getting away from mysql_* functions and move to PDO. When you do, use prepared/parameterized queries to avoid SQL injection and related problems. Also in your HTML, use htmlspecialchars() around any arbitrary data. Finally, your HTML is a bit of a mess... make sure you properly close your quotes. And, even though it isn't strictly required in HTML5, you will have an easier time by actually using quotes around attribute values consistently. — Brad
– Brad, Commented Aug 21, 2014 at 2:58

cameronjonesweb · Accepted Answer · 2014-08-21 04:00:13Z

1

You might want to add in the final apostrophe after timesubmit

echo "<form action='enter_time.php?uid=" . $userid . "?action=timesubmit' method='post'>";

edited Aug 21, 2014 at 4:00

answered Aug 21, 2014 at 2:56

cameronjonesweb

2,5363 gold badges27 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jeff P. Over a year ago

I figured out the answer. It was actually a combination of the missing single apostrophe after 'timesubmit' and changing my method from 'get' to 'post'. The 'submit' click works fine now. Thank you all!

Michael Over a year ago

@JeffP. Don't put GET variables in your action attribute like that, you should be hiding all of your variables inside form input elements.

ted · Accepted Answer · 2014-08-21 02:58:20Z

1

You have a quote after uid that should not be there:

"<form action='enter_time.php?uid=" . $userid . "?action=timesubmit method='get'>";

answered Aug 21, 2014 at 2:58

ted

14.9k10 gold badges70 silver badges117 bronze badges

Comments

Michael · Accepted Answer · 2014-08-21 03:11:07Z

If you are using a form to submit GET variables into a url you could do something like

<a id="submit_time<?= $time_cell_row . $time_cell_column ?>" href="enter_time.php?uid=<?= $userid ?>">Submit Time</a>

If you prefer to use a form, writing it this way looks clearer to me

PHP

<?php

$getuserid_result = mysql_query($getuseridsql, $conn);
$userid_array = mysql_fetch_array($getuserid_result);

$userid = $userid_array['uid']; 

// Above code works fine and retrieves the current user's ID

// PHP Form code is below

// Variables used for creating the id of the input since the submit button is displayed
// in an HTML table with multiple rows.  These variables are working fine.
$time_cell_row = 1;
$time_cell_column = 1;

?>

<form action='enter_time.php' method='get'>
    <input type="hidden" name="action" value="<?= $timesubmit ?>">
    <input type="hidden" name="uid" value="<?= userid ?>">
    <input name="submit_time" type="submit" id="submit_time<?= $time_cell_row . $time_cell_column ?>" />
</form>

<?php 
// PHP Action code

/* This is currently commented out and will eventually be filled with code to handle 
     the 'timesubmit' action 

            if (isset($_GET['action'])) { 
        switch (strtolower($_GET['action'])) {
            case 'timesubmit':



        }
     } 
            */

?>

Randy R · Accepted Answer · 2014-08-21 03:17:11Z

1

Just off top of my head it should be:

echo "<form action='enter_time.php?uid=" . $userid . "?action=timesubmit' method='get'>";

Single quote after "uid=" was in the wrong place. Shouldn't be until after "timesubmit".

edited Aug 21, 2014 at 3:17

answered Aug 21, 2014 at 2:56

Randy R

3224 silver badges14 bronze badges

Collectives™ on Stack Overflow

PHP: using an html Form to call up a PHP action

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related