Replace character in string with another string?

Question

I'm having trouble replacing characters in a string.

Here's the code I currently have:

var entry_value = document.getElementById("entry_box").value;
var length = entry_value.length;

for(var l = 0; l < length; l += 1) {
    letter = encoded[l]
    encoded = entry_value.replace(letter, "b")
}

This will only replace the first instance of letter with b, my question is how do I replace every instance of letter throughout the string?

your code is invalid, try l < l.length

ponciste
– ponciste

2014-02-16 13:21:55 +00:00
Commented Feb 16, 2014 at 13:21 — ponciste
– ponciste, Commented Feb 16, 2014 at 13:21
the variable 'length' is defined before the for loop

jabbawabba
– jabbawabba

2014-02-16 13:23:08 +00:00
Commented Feb 16, 2014 at 13:23 — jabbawabba
– jabbawabba, Commented Feb 16, 2014 at 13:23

salezica · Accepted Answer · 2014-02-16 13:49:47Z

3

You need to use a global regular expression instead of a string as pattern:

"aaaa".replace("a", "b")   // "baaa"
"aaaa".replace(/a/g, "b")  // "bbbb"

Try this:

encoded = entry_value.replace(new RegExp(letter, "g"), "b")

answered Feb 16, 2014 at 13:49

salezica

77.5k29 gold badges113 silver badges168 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

thefourtheye · Accepted Answer · 2014-02-16 13:22:45Z

3

You can simply do

entry_value = entry_value.split(letter).join("b");

For example,

var entry_value = "abcdcfchij";
entry_value = entry_value.split("c").join("b");
console.log(entry_value);     // abbdbfbhij

answered Feb 16, 2014 at 13:22

thefourtheye

241k53 gold badges466 silver badges505 bronze badges

Collectives™ on Stack Overflow

Replace character in string with another string?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related