Nullpointer exception in fragment (initializing listview)

Question

Here's my code for trying to display a list in a Fragment, which as of now keeps reporting a NullPointerException whenever it tries to initialize the ListView:

public class PortfolioFragment extends ListFragment {

ListView l;
ArrayAdapter<String> adapter;
List<String> list;

public PortfolioFragment() {
    // Required empty public constructor
}

public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);                

}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
        Bundle savedInstanceState) {
    // Inflate the layout for this fragment
    list = MainActivity.globalArrayTest;
    l = (ListView) getView().findViewById(android.R.id.list);
    adapter = new ArrayAdapter<String>(getActivity(), android.R.layout.simple_list_item_1, list);
    l.setAdapter(adapter);

    return inflater.inflate(R.layout.fragment_portfolio, container, false);

}

I am getting an error at this line:

l = (ListView) getView().findViewById(android.R.id.list);

you should use the inflater to find your view. See @Raghunandan 's answer — Mario Stoilov
– Mario Stoilov, Commented Dec 17, 2013 at 14:35

Raghunandan · Accepted Answer · 2013-12-17 14:40:07Z

4

Change to

View v = inflater.inflate(R.layout.fragment_portfolio, container, false);
l = (ListView) v.findViewById(android.R.id.list);
return v;

You should have the below in xml

<ListView android:id="@android:id/list"

Or override onActivityCreated and use getListView()

Also you can use the below as black belt commented this is better than the above.

@Override
public void onActivityCreated(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onActivityCreated(savedInstanceState);
            l = getListView(); // since you extend ListFragment
}

edited Dec 17, 2013 at 14:40

answered Dec 17, 2013 at 14:32

Raghunandan

134k26 gold badges232 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Blackbelt Over a year ago

getListView is the best solution in this case

Blackbelt · Accepted Answer · 2013-12-17 14:34:54Z

3

since you are extending ListFragment you should use getListView() instead of findViewById and setListAdapter should be called after onCreateView (inside onActivityCreated, for instance)

answered Dec 17, 2013 at 14:34

Blackbelt

158k31 gold badges308 silver badges310 bronze badges

Comments

Ojonugwa Jude Ochalifu · Accepted Answer · 2015-04-01 08:41:57Z

This is another way to go about this, although I extend only Fragment

 @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, 
                                          Bundle SavedInstanceState) {

            View rootView = inflater.inflate(R.layout.fragment_item, container, false);


            ListView itemList = (ListView)rootView.findViewById(R.id.itemListView);


     String[] items = {"Alpha", "Orange", "Pineapple", "Venus", "Echo", "Pent", "Mouse", 
                      "Phoenix", "Dent", "Sloppy"};


         ArrayAdapter<String> adapter = new ArrayAdapter<String>(rootView.getContext(),
                      R.layout.text_row, items);

  itemList.setAdapter(new ArrayAdapter<>(rootView.getContext(), 
                             R.layout.fragment_item, items));

    itemList.setAdapter(adapter);


    return (rootView);
}

Collectives™ on Stack Overflow

Nullpointer exception in fragment (initializing listview)

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related