If Else Conditionals within Function in JavaScript

Question

I'm having issues with conditionals. I want to return the index where pattern starts in string (or -1 if not found). The search is to be case sensitive if the 3rd parameter is true otherwise it is case insensitive.

Examples
index("abAB12","AB",true) returns 2 but index("abAB12","AB",false) returns 0
index("abAB12","BA",true) returns -1 and index("abAB12","BA",false) returns 1

Any idea how I can accomplish this?

This is my code so far

var s = "abAB12"
var p = "AB"
var cs = true

    function index(string, pattern, caseSensitive) {

        if (pattern) {

            var found = false;

            if (caseSensitive = false) {
                if (string.indexOf(pattern.) >= 0) {
                    found = true;
                }
                return (found);
                else {
                    return ("");
                }
            } else if (caseSensitive = true) {
                if (string.toLowerCase().indexOf(pattern.toLowerCase()) >= 0) {
                    found = true;
                }
                return (found);
            } else {
                return ("");
            }
        }

    }

alert(index(s, p, cs));

Fiddle at http://jsfiddle.net/AfDFb/1/

akinuri · Accepted Answer · 2013-11-09 15:50:47Z

2

You have some mistype in your code. On the 15th line you have

}
return (found);
else {

This is not not valid. Change it to

return (found);
}
else {

There is another one.

if (caseSensitive = false) {

= used for assignment. You need to use == in if statements when comparing. Also on the 13th line, there's an extra . after pattern. Remove it.

if (string.indexOf(pattern.) >= 0) {

Your fiddle example

answered Nov 9, 2013 at 15:50

akinuri

12.3k10 gold badges75 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ibrahim Najjar · Accepted Answer · 2013-11-09 15:47:26Z

2

You can use string.search() with a regular expression to accomplish this in one liner:

function index(input, key, caseMatters) {
    return input.search(new RegExp(key, caseMatters ? '' : 'i'));
}

Now you can:

index("abAB12","AB",true); // returns 2
index("abAB12","AB",false); // returns 0
index("abAB12","BA",true); // returns -1
index("abAB12","BA",false); // returns 1

edited Nov 9, 2013 at 15:47

answered Nov 9, 2013 at 15:42

Ibrahim Najjar

19.5k4 gold badges74 silver badges96 bronze badges

Comments

Muhammad Reda · Accepted Answer · 2013-11-09 15:42:32Z

0

You need to use double equals sign == in your if, else statements.

if(caseSensitive == false)

And

if(caseSensitive == true)

answered Nov 9, 2013 at 15:42

Muhammad Reda

27.1k14 gold badges100 silver badges107 bronze badges

Comments

Vicky Gonsalves · Accepted Answer · 2013-11-09 15:54:56Z

0

You are assigning value inside if condition instead of comparing it.

Try

 if (caseSensitive == false) {

and

 if(caseSensitive == true)

edited Nov 9, 2013 at 15:54

answered Nov 9, 2013 at 15:40

Vicky Gonsalves

11.8k3 gold badges39 silver badges58 bronze badges

Comments

score 0 · Accepted Answer · 2013-11-09 16:00:37Z

0

You'd better use search :

'abAB12'.search(/AB/); // 2
'abAB12'.search(/AB/i); // 0
'abAB12'.search(/BA/); // -1
'abAB12'.search(/BA/i); // 1

The i flag means "case insensitive" ( insensible à la casse :D ).

edited Nov 9, 2013 at 16:00

answered Nov 9, 2013 at 15:42

user1636522

Collectives™ on Stack Overflow

If Else Conditionals within Function in JavaScript

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related