replace part of a string using jquery

Question

would like some help replacing a part of a string using jquery, so here is what i have:

http://www.test.com/santa-cruz-island/?iframe=true&width=60%&height=70%

i would like to replace all the content from ?iframe= up to the end:

up to now i have this:

jQuery('.islands_info_ggt').each(function() {
         url = jQuery(this).attr('href');
        _imgr = url.replace('iframe=', 'test');

    jQuery(this).attr('href', _imgr)
});

Result: http://www.test.com/santa-cruz-island/?testtrue&width=60%&height=70%

This is the result im looking for: http://www.test.com/santa-cruz-island/?test

raina77ow · Accepted Answer · 2013-10-30 18:01:03Z

7

Use regex replace instead:

_imgr = url.replace(/iframe=.*$/, 'test');

BTW, you don't have to wrap all these elements in jQuery: this...

jQuery('.islands_info_ggt').each(function() {
  this.href = this.href.replace(/iframe=.*$/, 'test');
});

... will give you the same result, I suppose. In fact, you can use even more concise .attr(name, function) form:

jQuery('.islands_info_ggt').attr('href', function(_, attr) {
   return attr.replace(/iframe=.*$/, 'test');
});

edited Oct 30, 2013 at 18:01

answered Oct 30, 2013 at 17:55

raina77ow

107k16 gold badges205 silver badges240 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user400654 Over a year ago

or even jQuery('.islands_info_ggt').attr("href",function(attr){ return attr.replace(...

raina77ow Over a year ago

@KevinB Thanks, totally forgot about that. )

Venkata Krishna · Accepted Answer · 2013-10-30 17:55:32Z

4

For a non-regex solution, You could split & then take the first element

var url = "http://www.test.com/santa-cruz-island/?iframe=true&width=60%&height=70%";
var finalurl = url.split('iframe=')[0] + "test";

result - http://www.test.com/santa-cruz-island/?test

answered Oct 30, 2013 at 17:55

Venkata Krishna

15.2k5 gold badges45 silver badges57 bronze badges

Comments

vaichidrewar · Accepted Answer · 2013-10-30 17:56:37Z

1

Currently it is matching only 'iframe=.'. So you need .* so that it will match all the characters after it and $ to indicate the end.

url.replace('/iframe=.*$/', 'test');

answered Oct 30, 2013 at 17:56

vaichidrewar

9,65119 gold badges75 silver badges88 bronze badges

Comments

Guffa · Accepted Answer · 2013-10-30 17:58:05Z

1

You can use indexOf to find the location of "iframe=" in the string, get only the part of the string before that, and add whatever you want after it:

_imgr = url.substr(0, url.indexOf('iframe=')) + 'test';

answered Oct 30, 2013 at 17:58

Guffa

703k111 gold badges760 silver badges1k bronze badges

Comments

Waclock · Accepted Answer · 2013-10-30 17:57:24Z

0

You could use Regex:

_imgr = url.replace(/iframe=.*$/, 'test');

answered Oct 30, 2013 at 17:57

Waclock

1,73620 silver badges38 bronze badges

Comments

Hogan · Accepted Answer · 2013-10-30 18:03:01Z

0

Do in code exactly what you want to do as directly as possible.

This will result in the clearest and most maintainable code.

In this case you want to take the sub string up to the location of the string of interest and add your string to it.

url = url.substr(0,url.indexOf('iframe=')-1)+'test';

Using an API like this to do exactly what you are trying to do will always make your code clearer to others who are trying to read it.

edited Oct 30, 2013 at 18:03

answered Oct 30, 2013 at 17:57

Hogan

70.7k10 gold badges83 silver badges119 bronze badges

Collectives™ on Stack Overflow

replace part of a string using jquery

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related