How to remove remaining commas from a string using JavaScript Regex?

Question

I am trying to make a dynamic address builder to be used in combination with GMap Geocoder.

My code is like the following:

HTML

<input type="text" class="address" />
<input type="text" class="city" />
<input type="text" class="state" />
<input type="text" class="zipCode" />
<input type="text" class="country" />

JavaScript

$('.address, .city, .state, .zipCode, .country').blur(
    function()
    {
        var address = '';

        address += $('.address').val() + ', ';
        address += $('.city').val() + ', ';
        address += $('.state').val() + ', ';
        address += $('.zipCode').val() + ', ';
        address += $('.country').val();

        console.log(address);
    }
);

The problem now :

When I blur the address field I am getting the following in my console:

MyAddress, , , ,

also, in some case (at least for my area) there are two names for the same location and we use coma to separate them. In example the address can become something like that:

MyAddress, MySecondAddress, Cityname, State, zipCode, Country

The Question:

while the address is builded automatically, how can I remove the remaining commas from the address string by using regex?

Why don't you choose approach and only add the non-empty strings to address? — Reeno
– Reeno, Commented Sep 26, 2013 at 7:11
Is there any reason why you use the "class" parameter to identify your fields, instead of the "id" parameter? — Michaël Benjamin Saerens
– Michaël Benjamin Saerens, Commented Sep 26, 2013 at 7:22

raina77ow · Accepted Answer · 2013-09-26 07:26:13Z

3

One possible approach:

address = address.replace(/,(?:\s*,)+/g, ',').replace(/^,|,$/g, '');

But actually, I would probably do it a bit differently: collect all the non-empty values into an array, then join this array with ',':

var $addressFields = $('.address, .city, .state, .zipCode, .country');

$addressFields.blur(function() {
  var nonEmptyParts = $.map($addressFields, function(inp) {
    var inputStr = $.trim(inp.value);
    return inputStr === '' ? null : inputStr;
  });
  var fullAddress = nonEmptyParts.join(',');
  console.log(fullAddress);
});

I've employed a convenient feature of $.map here: when the callback function returns null (or undefined), the value is not added to the resulting array.

edited Sep 26, 2013 at 7:26

answered Sep 26, 2013 at 7:10

raina77ow

107k16 gold badges205 silver badges240 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

KodeFor.Me Over a year ago

The first approach didn't worked well. For some reason the second replace method didn't worked. I have try many other combinations for that, but still didn't work. Anyway, the second approach is what I need !! Thanks a lot :)

Justin K · Accepted Answer · 2013-09-26 09:46:23Z

You should correct the root of the problem instead of removing the extra commas. In the first place you should not add the commas in this way; as you can see it's adding commas even if the field is empty.

Please try something like this:

HTML:

<form id="myform">
    <input type="text" class="address" name="address" />
    <input type="text" class="city" name="city" />
    <input type="text" class="state" name="state" />
    <input type="text" class="zipCode" name="zipCode" />
    <input type="text" class="country" name="country" />
</form>

JS:

var address = [];

// no need for that long line of selectors
$("#myform > input").blur(function(e){
    if ($(this).val()) { // only add this field if it has a value
        address.push($(this).val());
    }
    console.log(address.join(', ')); // tada, no more extra commas
});

If your form has other inputs, use a div to group the inputs instead.

Martijn · Accepted Answer · 2013-09-26 09:35:35Z

0

address = address.replace(/( ?,)+/, '');

edited Sep 26, 2013 at 9:35

answered Sep 26, 2013 at 7:12

Martijn

16.2k4 gold badges39 silver badges73 bronze badges

1 Comment

raina77ow Over a year ago

Using replace with a string param instead of regex one -> just a single replacement. Besides, even if this solution worked, it wouldn't remove the trailing commas.

Collectives™ on Stack Overflow

How to remove remaining commas from a string using JavaScript Regex?

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related