asp.net mvc @Html.CheckBoxFor

Question

I have checkboxes in my form
enter image description here

I added at my model

 using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Web;

 namespace CorePartners_Site2.Models
 {
public class CareerForm
     {
    //....
    public List<CheckBoxes> EmploymentType { get; set; } 
      }
 }

 public class CheckBoxes
 {
     public string Text { get; set; }
     public bool Checked { get; set; }
 }

and added at my form

@Html.CheckBoxFor(model => model.EmploymentType, new { id = "employmentType_1" })
@Html.CheckBoxFor(model => model.EmploymentType, new { id = "employmentType_2" })
@Html.CheckBoxFor(model => model.EmploymentType, new { id = "employmentType_3" })

but I get the mistake
enter image description here

What's wrong?

Junior · Accepted Answer · 2017-10-06 14:47:14Z

38

CheckBoxFor takes a bool, you're passing a List<CheckBoxes> to it. You'd need to do:

@for (int i = 0; i < Model.EmploymentType.Count; i++)
{
    @Html.CheckBoxFor(m => m.EmploymentType[i].Checked, new { id = "employmentType_" + i })
    @Html.HiddenFor(m => m.EmploymentType[i].Text)
    @Html.DisplayFor(m => m.EmploymentType[i].Text)
}

Notice I've added a HiddenFor for the Text property too, otherwise you'd lose that when you posted the form, so you wouldn't know which items you'd checked.

Edit, as shown in your comments, your EmploymentType list is null when the view is served. You'll need to populate that too, by doing this in your action method:

public ActionResult YourActionMethod()
{
    CareerForm model = new CareerForm();

    model.EmploymentType = new List<CheckBox>
    {
        new CheckBox { Text = "Fulltime" },
        new CheckBox { Text = "Partly" },
        new CheckBox { Text = "Contract" }
    };

    return View(model);
}

edited Oct 6, 2017 at 14:47

Junior

12.1k33 gold badges123 silver badges229 bronze badges

answered May 22, 2013 at 9:33

Mathew Thompson

56.5k15 gold badges131 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Mathew Thompson Over a year ago

@Heidel Yeah inside your form

Heidel Over a year ago

I tried, but I got this http://i.imgur.com/Q78xcBD.png. what's wrong?

Heidel Over a year ago

Should I add at my model something?

Mathew Thompson Over a year ago

@Heidel Check my edit, you need to populate the EmploymentType list.

Mathew Thompson Over a year ago

@Heidel The name has to be like that, so that when you post the form the model binder can correctly bind back to your list.

|

Oliver · Accepted Answer · 2013-05-22 09:36:22Z

3

Html.CheckBoxFor expects a Func<TModel, bool> as the first parameter. Therefore your lambda must return a bool, you are currently returning an instance of List<Checkboxes>:

model => model.EmploymentType

You need to iterate over the List<Checkboxes> to output each checkbox:

@for (int i = 0; i < Model.EmploymentType.Count; i++)
{
    @Html.HiddenFor(m => m.EmploymentType[i].Text)
    @Html.CheckBoxFor(m => m.EmploymentType[i].Checked, 
              new { id = string.Format("employmentType_{0}", i) })
}

answered May 22, 2013 at 9:36

Oliver

9,0222 gold badges45 silver badges63 bronze badges

Comments

user1968030 · Accepted Answer · 2013-05-22 09:35:09Z

2

Use this code:

@for (int i = 0; i < Model.EmploymentType.Count; i++)
{
    @Html.HiddenFor(m => m.EmploymentType[i].Text)
    @Html.CheckBoxFor(m => m.EmploymentType[i].Checked, new { id = "YourId" })
}

answered May 22, 2013 at 9:35

user1968030

Comments

Kamil Będkowski · Accepted Answer · 2013-05-22 09:56:26Z

1

If only one checkbox should be checked in the same time use RadioButtonFor instead:

      @Html.RadioButtonFor(model => model.Type,1, new { @checked = "checked" }) fultime
      @Html.RadioButtonFor(model => model.Type,2) party
      @Html.RadioButtonFor(model => model.Type,3) next option...

If one more one could be checked in the same time use excellent extension: CheckBoxListFor:

Hope,it will help

answered May 22, 2013 at 9:56

Kamil Będkowski

1,0924 gold badges18 silver badges37 bronze badges

Collectives™ on Stack Overflow

asp.net mvc @Html.CheckBoxFor

4 Answers 4

7 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

7 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related