94

Why doesn't Typescript warn me that the function I am defining does not match the interface declaration, but it does warn me if I try to invoke the function.

interface IFormatter {
    (data: string, toUpper : boolean): string;
};

//Compiler does not flag error here.
var upperCaseFormatter: IFormatter = function (data: string) {
    return data.toUpperCase();
}  

upperCaseFormatter("test"); //but does flag an error here.

1 Answer 1

126

The interface ensures that all callers of functions that implement the interface supply the required arguments - data and toUpper.

Because TypeScript understands that JavaScript doesn't mind if you pass arguments that aren't used, it cleverly allows this in implementations.

Why is this okay? Because it means you can substitute any implementation of the interface without affecting calling code.

Example: You can substitute either IFormatter implementation and the code works.

interface IFormatter {
    (data: string, toUpper: boolean): string;
};

var upperCaseFormatter: IFormatter = function (data: string) {
    return data.toUpperCase();
}

var variableCaseFormatter: IFormatter = function (data: string, toUpper: boolean) {
    if (toUpper) {
        return data.toUpperCase();
    }

    return data.toLowerCase();
}

// Switch between these at will
//var formatter = upperCaseFormatter;
var formatter = variableCaseFormatter;

formatter("test", true);

If TypeScript didn't do this, your upperCaseFormatter would have to have to have a parameter called toUpper that wasn't used anywhere in the function - which makes the code less readable.

Sign up to request clarification or add additional context in comments.

5 Comments

But then using upperCaseFormatter has a redundant boolean value: upperCaseFormatter("test", true); // excluding the 'true' will result in a compiler warning. So instead the interface is wrong and should be: interface IFormatter { (data: string, toUpper? : bool): string; } But this then means that you can invoke variableCaseFormatter with just variableCaseFormatter('test'); without specifying toUpper despite it being in the function signature. See my question here for a simpler example of my current confusion: stackoverflow.com/questions/23305020
@AJP if you were writing clean code, you would never write a variable case formatter. You would write one class for upper and one for lower and avoid the nasty boolean argument altogether.
@AJP In the case that you call upperCaseFormatter directly the interface is irrelevant.
Is there a better syntax for providing such a function interface to an object method? eg. { <IFormatter>myMethod() {return;} }
This is totally wrong behavior of an interface IMO, Just look at other OOP languages

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.