-
Notifications
You must be signed in to change notification settings - Fork 1.2k
KotlinCoroutineFilter should filter suspension points that return inline value classes #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Godin
merged 4 commits into
jacoco:master
from
Godin:kotlin_suspending_function_returning_inline_value_class
Sep 22, 2025
Merged
KotlinCoroutineFilter should filter suspension points that return inline value classes #1871
Godin
merged 4 commits into
jacoco:master
from
Godin:kotlin_suspending_function_returning_inline_value_class
Sep 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
674fd39 to
7caa090
Compare
leveretka
approved these changes
Sep 22, 2025
Collaborator
leveretka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Comment on lines
148
to
-167
| } | ||
|
|
||
| for (AbstractInsnNode j = i; j != null; j = j.getNext()) { | ||
| cursor = j; | ||
| nextIs(Opcodes.ALOAD); | ||
| nextIsThrowOnFailure(); | ||
|
|
||
| nextIs(Opcodes.ALOAD); | ||
| if (cursor != null && skipNonOpcodes(cursor | ||
| .getNext()) == continuationAfterLoadedResult) { | ||
| ignore.add(i); | ||
| ignore.add(cursor); | ||
| suspensionPoint++; | ||
| break; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, the simplified logic here still detects desired generated code, so no need to have a very precise matcher here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
src/Utils.ktcompilation of
src/Example.ktdiffers from compilation of
src/Example.ktas
and
jacoco/org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinCoroutineFilter.java
Lines 130 to 135 in 78d5eff
does not handle
JetBrains/kotlin@ccc5b7a
See #1868 (comment) and #1868 (comment)