changeset: 97490:d93bb3d636cf branch: 3.5 parent: 97475:5a9ac801f9b4 user: R David Murray date: Sat Aug 15 18:33:45 2015 -0400 files: Include/pymath.h Misc/ACKS Misc/NEWS description: #21167: Fix definition of NAN when ICC used without -fp-model strict. Patch from Chris Hogan of Intel, reviewed by Mark Dickinson. diff -r 5a9ac801f9b4 -r d93bb3d636cf Include/pymath.h --- a/Include/pymath.h Tue Aug 11 18:59:15 2015 -0700 +++ b/Include/pymath.h Sat Aug 15 18:33:45 2015 -0400 @@ -150,7 +150,29 @@ * doesn't support NaNs. */ #if !defined(Py_NAN) && !defined(Py_NO_NAN) -#define Py_NAN (Py_HUGE_VAL * 0.) +#if !defined(__INTEL_COMPILER) + #define Py_NAN (Py_HUGE_VAL * 0.) +#else /* __INTEL_COMPILER */ + #if defined(ICC_NAN_STRICT) + #pragma float_control(push) + #pragma float_control(precise, on) + #pragma float_control(except, on) + #if defined(_MSC_VER) + __declspec(noinline) + #else /* Linux */ + __attribute__((noinline)) + #endif /* _MSC_VER */ + static double __icc_nan() + { + return sqrt(-1.0); + } + #pragma float_control (pop) + #define Py_NAN __icc_nan() + #else /* ICC_NAN_RELAXED as default for Intel Compiler */ + static union { unsigned char buf[8]; double __icc_nan; } __nan_store = {0,0,0,0,0,0,0xf8,0x7f}; + #define Py_NAN (__nan_store.__icc_nan) + #endif /* ICC_NAN_STRICT */ +#endif /* __INTEL_COMPILER */ #endif /* Py_OVERFLOWED(X) diff -r 5a9ac801f9b4 -r d93bb3d636cf Misc/ACKS --- a/Misc/ACKS Tue Aug 11 18:59:15 2015 -0700 +++ b/Misc/ACKS Sat Aug 15 18:33:45 2015 -0400 @@ -594,6 +594,7 @@ Chris Hoffman Stefan Hoffmeister Albert Hofkamp +Chris Hogan Tomas Hoger Jonathan Hogg Kamilla Holanda diff -r 5a9ac801f9b4 -r d93bb3d636cf Misc/NEWS --- a/Misc/NEWS Tue Aug 11 18:59:15 2015 -0700 +++ b/Misc/NEWS Sat Aug 15 18:33:45 2015 -0400 @@ -10,6 +10,9 @@ Core and Builtins ----------------- +- Issue #21167: NAN operations are now handled correctly when python is + compiled with ICC even if -fp-model strict is not specified. + Library -------