Skip to content

Commit 1a6f59a

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: extend timeouts for deleting snapshots, backups and tables (#1387)
* build: update gapic-generator-typescript to v4.4.1 PiperOrigin-RevId: 604765466 Source-Link: googleapis/googleapis@40203ca Source-Link: googleapis/googleapis-gen@07b7f3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDdiN2YzZGFkOGFhMTkxMmQ0YWNkY2ZkNjM2NWJiNDIzNmU0YjU0YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: extend timeouts for deleting snapshots, backups and tables PiperOrigin-RevId: 605388988 Source-Link: googleapis/googleapis@fbcfef0 Source-Link: googleapis/googleapis-gen@716b6e6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzE2YjZlNmE2YTBlOGM4N2E0OGE4NmUzMTI3MmEyODI2ZjJkZjM4YyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent c0c287e commit 1a6f59a

7 files changed

+24
-70
lines changed

‎src/v2/bigtable_client.ts‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ export class BigtableClient {
332332

333333
/**
334334
* The DNS address for this API service.
335-
* @deprecated
335+
* @deprecated Use the apiEndpoint method of the client instance.
336336
* @returns {string} The DNS address for this service.
337337
*/
338338
static get servicePath() {
@@ -349,9 +349,8 @@ export class BigtableClient {
349349
}
350350

351351
/**
352-
* The DNS address for this API service - same as servicePath,
353-
* exists for compatibility reasons.
354-
* @deprecated
352+
* The DNS address for this API service - same as servicePath.
353+
* @deprecated Use the apiEndpoint method of the client instance.
355354
* @returns {string} The DNS address for this service.
356355
*/
357356
static get apiEndpoint() {
@@ -371,14 +370,6 @@ export class BigtableClient {
371370
* The DNS address for this API service.
372371
* @returns {string} The DNS address for this service.
373372
*/
374-
get servicePath() {
375-
return this._servicePath;
376-
}
377-
378-
/**
379-
* The DNS address for this API service - same as servicePath().
380-
* @returns {string} The DNS address for this service.
381-
*/
382373
get apiEndpoint() {
383374
return this._servicePath;
384375
}

‎src/v2/bigtable_instance_admin_client.ts‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ export class BigtableInstanceAdminClient {
450450

451451
/**
452452
* The DNS address for this API service.
453-
* @deprecated
453+
* @deprecated Use the apiEndpoint method of the client instance.
454454
* @returns {string} The DNS address for this service.
455455
*/
456456
static get servicePath() {
@@ -467,9 +467,8 @@ export class BigtableInstanceAdminClient {
467467
}
468468

469469
/**
470-
* The DNS address for this API service - same as servicePath,
471-
* exists for compatibility reasons.
472-
* @deprecated
470+
* The DNS address for this API service - same as servicePath.
471+
* @deprecated Use the apiEndpoint method of the client instance.
473472
* @returns {string} The DNS address for this service.
474473
*/
475474
static get apiEndpoint() {
@@ -489,14 +488,6 @@ export class BigtableInstanceAdminClient {
489488
* The DNS address for this API service.
490489
* @returns {string} The DNS address for this service.
491490
*/
492-
get servicePath() {
493-
return this._servicePath;
494-
}
495-
496-
/**
497-
* The DNS address for this API service - same as servicePath().
498-
* @returns {string} The DNS address for this service.
499-
*/
500491
get apiEndpoint() {
501492
return this._servicePath;
502493
}

‎src/v2/bigtable_table_admin_client.ts‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ export class BigtableTableAdminClient {
470470

471471
/**
472472
* The DNS address for this API service.
473-
* @deprecated
473+
* @deprecated Use the apiEndpoint method of the client instance.
474474
* @returns {string} The DNS address for this service.
475475
*/
476476
static get servicePath() {
@@ -487,9 +487,8 @@ export class BigtableTableAdminClient {
487487
}
488488

489489
/**
490-
* The DNS address for this API service - same as servicePath,
491-
* exists for compatibility reasons.
492-
* @deprecated
490+
* The DNS address for this API service - same as servicePath.
491+
* @deprecated Use the apiEndpoint method of the client instance.
493492
* @returns {string} The DNS address for this service.
494493
*/
495494
static get apiEndpoint() {
@@ -509,14 +508,6 @@ export class BigtableTableAdminClient {
509508
* The DNS address for this API service.
510509
* @returns {string} The DNS address for this service.
511510
*/
512-
get servicePath() {
513-
return this._servicePath;
514-
}
515-
516-
/**
517-
* The DNS address for this API service - same as servicePath().
518-
* @returns {string} The DNS address for this service.
519-
*/
520511
get apiEndpoint() {
521512
return this._servicePath;
522513
}

‎src/v2/bigtable_table_admin_client_config.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"retry_params_name": "default"
5454
},
5555
"DeleteTable": {
56-
"timeout_millis": 60000,
56+
"timeout_millis": 300000,
5757
"retry_codes_name": "non_idempotent",
5858
"retry_params_name": "default"
5959
},
@@ -96,7 +96,7 @@
9696
"retry_params_name": "264268458a9e88347dbacbd9398202ff5885a40b"
9797
},
9898
"DeleteSnapshot": {
99-
"timeout_millis": 60000,
99+
"timeout_millis": 300000,
100100
"retry_codes_name": "non_idempotent",
101101
"retry_params_name": "default"
102102
},
@@ -116,7 +116,7 @@
116116
"retry_params_name": "default"
117117
},
118118
"DeleteBackup": {
119-
"timeout_millis": 60000,
119+
"timeout_millis": 300000,
120120
"retry_codes_name": "non_idempotent",
121121
"retry_params_name": "default"
122122
},

‎test/gapic_bigtable_instance_admin_v2.ts‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -161,13 +161,6 @@ function stubAsyncIterationCall<ResponseType>(
161161

162162
describe('v2.BigtableInstanceAdminClient', () => {
163163
describe('Common methods', () => {
164-
it('has servicePath', () => {
165-
const client =
166-
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient();
167-
const servicePath = client.servicePath;
168-
assert.strictEqual(servicePath, 'bigtableadmin.googleapis.com');
169-
});
170-
171164
it('has apiEndpoint', () => {
172165
const client =
173166
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient();
@@ -206,21 +199,21 @@ describe('v2.BigtableInstanceAdminClient', () => {
206199
stub.restore();
207200
});
208201
}
209-
it('sets servicePath according to universe domain camelCase', () => {
202+
it('sets apiEndpoint according to universe domain camelCase', () => {
210203
const client =
211204
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient({
212205
universeDomain: 'example.com',
213206
});
214-
const servicePath = client.servicePath;
207+
const servicePath = client.apiEndpoint;
215208
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
216209
});
217210

218-
it('sets servicePath according to universe domain snakeCase', () => {
211+
it('sets apiEndpoint according to universe domain snakeCase', () => {
219212
const client =
220213
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient({
221214
universe_domain: 'example.com',
222215
});
223-
const servicePath = client.servicePath;
216+
const servicePath = client.apiEndpoint;
224217
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
225218
});
226219
it('does not allow setting both universeDomain and universe_domain', () => {

‎test/gapic_bigtable_table_admin_v2.ts‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,6 @@ function stubAsyncIterationCall<ResponseType>(
161161

162162
describe('v2.BigtableTableAdminClient', () => {
163163
describe('Common methods', () => {
164-
it('has servicePath', () => {
165-
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient();
166-
const servicePath = client.servicePath;
167-
assert.strictEqual(servicePath, 'bigtableadmin.googleapis.com');
168-
});
169-
170164
it('has apiEndpoint', () => {
171165
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient();
172166
const apiEndpoint = client.apiEndpoint;
@@ -201,19 +195,19 @@ describe('v2.BigtableTableAdminClient', () => {
201195
stub.restore();
202196
});
203197
}
204-
it('sets servicePath according to universe domain camelCase', () => {
198+
it('sets apiEndpoint according to universe domain camelCase', () => {
205199
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient({
206200
universeDomain: 'example.com',
207201
});
208-
const servicePath = client.servicePath;
202+
const servicePath = client.apiEndpoint;
209203
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
210204
});
211205

212-
it('sets servicePath according to universe domain snakeCase', () => {
206+
it('sets apiEndpoint according to universe domain snakeCase', () => {
213207
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient({
214208
universe_domain: 'example.com',
215209
});
216-
const servicePath = client.servicePath;
210+
const servicePath = client.apiEndpoint;
217211
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
218212
});
219213
it('does not allow setting both universeDomain and universe_domain', () => {

‎test/gapic_bigtable_v2.ts‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@ function stubServerStreamingCall<ResponseType>(
8989

9090
describe('v2.BigtableClient', () => {
9191
describe('Common methods', () => {
92-
it('has servicePath', () => {
93-
const client = new bigtableModule.v2.BigtableClient();
94-
const servicePath = client.servicePath;
95-
assert.strictEqual(servicePath, 'bigtable.googleapis.com');
96-
});
97-
9892
it('has apiEndpoint', () => {
9993
const client = new bigtableModule.v2.BigtableClient();
10094
const apiEndpoint = client.apiEndpoint;
@@ -127,19 +121,19 @@ describe('v2.BigtableClient', () => {
127121
stub.restore();
128122
});
129123
}
130-
it('sets servicePath according to universe domain camelCase', () => {
124+
it('sets apiEndpoint according to universe domain camelCase', () => {
131125
const client = new bigtableModule.v2.BigtableClient({
132126
universeDomain: 'example.com',
133127
});
134-
const servicePath = client.servicePath;
128+
const servicePath = client.apiEndpoint;
135129
assert.strictEqual(servicePath, 'bigtable.example.com');
136130
});
137131

138-
it('sets servicePath according to universe domain snakeCase', () => {
132+
it('sets apiEndpoint according to universe domain snakeCase', () => {
139133
const client = new bigtableModule.v2.BigtableClient({
140134
universe_domain: 'example.com',
141135
});
142-
const servicePath = client.servicePath;
136+
const servicePath = client.apiEndpoint;
143137
assert.strictEqual(servicePath, 'bigtable.example.com');
144138
});
145139
it('does not allow setting both universeDomain and universe_domain', () => {

0 commit comments

Comments
 (0)